Repository navigation
Add WithCallback Feature - #3681
Closed
Not-Dhananjay-Mishra wants to merge 3 commits into
Closed
Not-Dhananjay-Mishra wants to merge 3 commits into
Not-Dhananjay-Mishra wants to merge 3 commits into
Conversation
Contributor
Author
|
Corrected the typo that caused the lint issue. I’m still learning, so thank you |
gmlewis
reviewed
Aug 16, 2025
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra - but I don't think this fully satisfies what is being requested in #3658.
Additionally, discussion has not completed in that issue, as there is an outstanding request to the original author to further clarify their request, so it is premature to be writing any PR for that issue yet.
Let's hold off on this PR until we get some more clarity, please.
Contributor
Author
|
Thanks @gmlewis for the clarification! I will hold off on the PR. I appreciate the guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the feature requested in [#3658] to allow configurable telemetry for the Client.
Modifications -
WithCallback(callback func())was added. The callback will be set by the user.client.bareDoinsideclient.Do.func(), which default set to nil duringinitialize().Example Code -
client := github.NewClient(nil).WithCallback(func() {fmt.Println("Callback executed")})This enables users to attach custom telemetry or logging kind of things to API calls in a flexible, user friendly manner.
Btw this is my first PR
Happy to get any feedback or suggestions to improve it