Repository navigation
fix(samples): pass headers in method options and add upload CLI argument check - #4058
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
…ent check In samples/youtube/playlist.js, pass custom ETag headers in the second MethodOptions parameter rather than mixed into API query params to adhere to the client signature contract. In samples/youtube/upload.js, add validation and usage guidance when executed directly without a file path argument. Validated with samples/test/test.samples.youtube.js. Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the YouTube API code samples in
samples/youtube/:samples/youtube/playlist.js): IngetPlaylistData(), passes the conditional ETag request headers via the secondMethodOptionsparameter ({ headers }) rather than mixed into the API query parameters object (params). This follows the library contract and ensures custom headers are cleanly applied as request options.samples/youtube/upload.js): Adds argument validation and usage instructions when runningnode upload.jsdirectly without specifying a file path, preventing unhandledTypeErrorexceptions fromfs.statSync(undefined).Testing
samples/test/test.samples.youtube.js(all 3 tests passing).