← 输入框|github.com|刷新
Skip to content

Tweak workgroup limit names #1929

Closed

Description

@kainino0x

Aside: now that I've been looking at it repeatedly, "workgroup invocations" confused me, it sounds like "number of workgroup invocations" not "number of invocations in a workgroup". Should we rename to, like, maxComputeWorkgroupVolume?

+1 on using some computeWorkgroupVolume terminology

Editors came up with "maxComputeInvocationsPerWorkgroup"

All together that would be:

  • maxComputeWorkgroupStorageSize, maybe maxWorkgroupStorage
  • maxComputeInvocationsPerWorkgroup, maybe maxInvocationsPerWorkgroup
  • maxComputeWorkgroupSize, maybe maxComputeWorkgroupDimensions

Originally posted by @kainino0x in #1898 (comment)

Activity

  1. added this to the MVP milestone on Jul 13, 2021
  2. kainino0x commented on Jul 26, 2021

    @kainino0x
    ContributorAuthor

    maxComputeWorkgroupStorageSize
    maxComputeInvocationsPerWorkgroup
    maxComputeWorkgroupDimensions

  3. self-assigned this
    on Jul 26, 2021
  4. kainino0x commented on Jul 26, 2021

    @kainino0x
    ContributorAuthor

    There is also maxComputePerDimensionDispatchSize, should it be maxComputeDispatchDimension or something? "Dimension" singular doesn't work as well as "dimensions" plural, unfortunately.

  5. added a commit that references this issue on Jul 26, 2021
    f296505
  6. added a commit that references this issue on Aug 4, 2021
    84615d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions