Repository navigation
Remove groupLabel parameter from popDebugGroup - #169
Merged
Merged
Conversation
Kangz
approved these changes
Jan 18, 2019
kainino0x
approved these changes
Jan 18, 2019
Contributor
|
To be honest, when I first skimmed over #126 I thought that this is intentional: it's not infrequent for developers to mess up the push/pop without realizing it, and it's a good practice to comment on the pop() like:
So making it a part of the API seems like it could be useful. HOWEVER. We don't need to be too creative here, and we are safe to leave those enhancements to whatever layers are atop of us :) TL;DR: PR is fine |
|
Yeah, this was my copy/paste typo in #121. Even my own polyfill of the API doesn't have that argument. |
RafaelCintron
approved these changes
Jan 27, 2019
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove groupLabel parameter from
popDebugGroup.popDebugGroupwas initially merged to the IDL in f6b5b25None of the backends allow you to pass the
groupLabelas a parameter. All backends will matchpopDebugGroupequivalent with the last calledpushDebugGroupequivalent.DX12 PIX
void PIXEndEvent(ID3D12GraphicsCommandList* commandList);[MSDN]Vulkan
void vkCmdDebugMarkerEndEXT(VkCommandBuffer commandBuffer);[Khronos]Metal
func popDebugGroup()[Apple]