Repository navigation
Preserve AST definitions across schema transformations - #4513
Merged
Merged
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (17 classes)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying enum values, applied directives, and applied directive arguments currently drops their AST definitions, even with an empty
transformcallback. Schema copy builders also drop the schema definition, andSchemaTransformerdrops both the schema definition and extensions when rebuilding a changed schema.Preserve this metadata consistently across copy builders,
transform,copy, andwithNewChildren, including both schema transformer variants. Retain the original AST nodes by reference; callers can explicitly replace or clear them. Document that runtime edits do not rewrite the original source AST.Also populate custom scalar extension definitions from the SDL registry when
captureAstDefinitionsis enabled, and clear them when it is disabled, matching the other type definitions.Regression tests cover all 13 AST-bearing schema element classes, schema copying and nested transformations, explicit clearing, unchanged source names after runtime renaming, and scalar capture with and without metadata supplied by wiring.
Validation:
./gradlew check javadocpassed (5,861 test cases, no failures; includes shaded-JAR verification and consumer compilation).