Repository navigation
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (2 classes)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spock, a schema with
input UserLookup @oneOf { byId: ID byEmail: String }run throughIntrospectionQuery.INTROSPECTION_QUERY,IntrospectionResultToSchema.createSchemaDefinition,AstPrinterandSchemaGenerator:createInputObjectnever reads__Type.isOneOf, so the rebuilt schema has a plain input object and{ user(lookup: {byId: "1", byEmail: "a@b.c"}) }passes validation and reaches the data fetcher, where the origin schema rejects it withExactly one key must be specified for OneOf type 'UserLookup'. the default introspection query asks forisOneOf, and also forisDeprecated/deprecationReasonon arguments and input fields, whichcreateInputValueDefinitionsdrops the same way while fields, enum values and directive definitions keep theirs. graphql-jsbuildClientSchemacarriesisOneOfand input value deprecation over.createInputObjectnow adds@oneOfwhenisOneOfis true and input values go through the existingcreateDeprecatedDirective. the regression tests inIntrospectionResultToSchemaTestfail before the change.