Repository navigation
Should not mark a connection as invalid after exception #274
Description
At com.github.jasync.sql.db.pool.ConnectionFactory#validate(), it will mark the connection as invalid after exception like sql syntax error or duplicate key. But the connection is still valid to use. I think only network/connection error should invalidate a connection
Activity
github-actions commentedon Dec 3, 2021
Thank you for reporting an issue. See the wiki for documentation and gitter for questions.
oshai commentedon Dec 5, 2021
IIRC the reason to do that is to avoid cases of buffers not getting cleaned and some edge cases. I think it's better to play it on the safe side on this case.
Do you see any implications with the current approach?
Perhaps we can "white-list" some errors that will not invalidate the connection (like the ones you mentioned above) by adding test cases for those.