Undefined Method java_kind_of? in JRuby-9.3.0.0 #6862

Activity

1. ThomasKoppensteiner commented on Sep 28, 2021

   

   ThomasKoppensteiner

   on Sep 28, 2021

   Author

   More actions

   Is java_kind_of? deprecated?

   Yes, it was deprecated in JRuby-9.2.19.0.

   See: https://github.com/jruby/jruby/blob/9.2.19.0/core/src/main/ruby/jruby/java/core_ext/object.rb#L13-L19

   # @deprecated
   def java_kind_of?(other) # TODO: this can go away now, but people may be using it
     return true if self.kind_of?(other)
     return false unless self.respond_to?(:java_class) && other.respond_to?(:java_class) &&
       other.kind_of?(Module) && !self.kind_of?(Module) 
     return other.java_class.assignable_from?(self.java_class)
   end
2. michaelklishin commented on Sep 29, 2021

   

   michaelklishin

   on Sep 29, 2021

   Contributor

   More actions

   So what are our options then? Use #assignable_from? instead?
3. enebo commented on Sep 29, 2021

   

   enebo

   on Sep 29, 2021

   Member

   More actions

   @ThomasKoppensteiner @michaelklishin Is kind_of? working for your needs here:

   a = java.util.ArrayList.new; p a.kind_of?(java.util.ArrayList) #=> true
   a = java.util.ArrayList.new; p a.kind_of?(java.util.List) #=> true
4. ThomasKoppensteiner commented on Sep 30, 2021

   

   ThomasKoppensteiner

   on Sep 30, 2021

   Author

   More actions

   @enebo thank you for your suggestion. I used it in this PR for march_hare ruby-amqp/march_hare#156.
5. enebo commented on Sep 30, 2021

   

   enebo

   on Sep 30, 2021

   Member

   More actions

   @ThomasKoppensteiner we talked about this on chat and realized for instance of sorts of checks kind_of? works but if you ask on Java type itself (e.g. java.util.ArrayList.kind_of?(java.lang.Class)) it does not. I think this is probably very uncommon but if you happen to ever notice this case we probably need to augment kind_of?.
6. olleolleolle commented on Oct 5, 2021

   

   olleolleolle

   on Oct 5, 2021

   Last edited by olleolleolle

   Member

   More actions

   The use-case in the ticket is the following:

   value.kind_of(com.rabbitmq.client.LongString) where value seems to be a Java value (we can see checks in there going value.is_a?(java.util.Map)).

   @enebo Would this be a valid?

   I searched for LONG_STRING_TYPE and found that value. https://github.com/ruby-amqp/march_hare/search?q=LONG_STRING_TYPE
7. headius commented on Oct 5, 2021

   

   headius

   on Oct 5, 2021

   Member

   More actions

   Would this be a valid?

   I believe these should work with kind_of? or is_a as appropriate. The Ruby view of the Java object uses the same class hierarchy as e.g. com.rabbitmw.client.LongString and it should be seen as a supertype of the object's class.
8. headius

   added this to the Won't Fix milestone on Oct 5, 2021
9. headius commented on Oct 5, 2021

   

   headius

   on Oct 5, 2021

   Member

   More actions

   Closing as won't fix since kind_of? should work for all interesting use cases.

   👍React with 👍1Reacted by Thomas Koppensteiner
10. headius

    closed this as completedon Oct 5, 2021
11. knoxknox

    added a commit that references this issue on Mar 29, 2022

    Fix kind_of (9.3.x)

    ...

    a53f8e3
12. AxelPatron commented on May 16, 2023

    

    AxelPatron

    on May 16, 2023

    Last edited by AxelPatron

    More actions

    Hello, I am using Logstash to process python script in my pipeline between SQL and ElasticSearch but if I use this filter in my logstash-sample.conf file
    filter { python { code => ' print("python works") ' } }
    I receive these logs :

    [2023-05-16T09:26:01,898][ERROR][logstash.filters.python ][main][9159e3828cc8f1ed140577832a7ee56f40772013e30def286e744cbc9c8f7eb1] Python exception occurred: undefined method java_kind_of?' for #Java::OrgPythonCore::PyObjectDerived:0x59f863d5
    Did you mean? java_send
    python works
    python works
    [2023-05-16T09:26:01,926][ERROR][logstash.filters.python ][main][9159e3828cc8f1ed140577832a7ee56f40772013e30def286e744cbc9c8f7eb1] Python exception occurred: undefined method java_kind_of?' for #<Java::OrgPythonCore::PyObjectDerived:0x1e55fe7e> Did you mean? java_send python works [2023-05-16T09:26:01,933][ERROR][logstash.filters.python ][main][9159e3828cc8f1ed140577832a7ee56f40772013e30def286e744cbc9c8f7eb1] Python exception occurred: undefined method java_kind_of?' for #Java::OrgPythonCore::PyObjectDerived:0x1e55fe7e`

    I am not sure it causes problems but what could I do to prevent that?
    I am using Logstash 8.6.2 wich uses JRuby to 9.3.10.0
13. enebo commented on May 16, 2023

    

    enebo

    on May 16, 2023

    Member

    More actions

    @AxelPatron I don't know how you insert Ruby into conf (or some other file which happens to be Ruby syntax) but if you figure out such a place you can:

    class Object; alias java_kind_of? kind_of?; end

    I am guessing java_kind_of? is still being used by whatever provides python support.