Repository navigation
node: Flush the chainstate on shutdown - #117
Merged
Merged
Conversation
The kernel writes the block index and coins database when the chainstate manager is destroyed. The IPC listener thread holds a reference and is never joined. A stopped node exits with the manager alive, and the next start syncs from genesis. Stop the listener with a oneshot and join it after shutdown. The oneshot needs tokio's sync feature.
Every test uses a fresh datadir, and none checks what a stopped node leaves on disk. Sync a node from Core, stop both, and restart the node with no peers. The tip it reports can only come from disk. stop returns the datadir for reuse. start_in removes the stale socket, which would otherwise pass the readiness check early.
rustaceanrob
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel writes the block index and coins database when the chainstate manager is destroyed. The IPC listener thread holds a reference and is never joined. A node stopped with
cli stopexits with the manager alive, and the next start syncs from genesis.Stop the listener with a oneshot and join it after shutdown. The added test syncs a node from Core, stops both, and restarts the node on the same datadir with no peers. On master the restarted node reports genesis instead of the synced tip.