← 输入框|github.com|刷新
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: learningequality/.github
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: learningequality/.github
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: issue-validation
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 17 files changed
  • 1 contributor

Commits on Oct 26, 2026

  1. Add the issue validation automations 

    A contributor opens an issue and nothing checks the claim in it. rtibblesbot
can now validate an issue it did not open, so ask it on every contributor
issue and mark the issue while the check runs.

The comment mentions the bot outside backticks. The agent polls its
notifications and holds no inbound endpoint, so the mention is the only way
to reach it.

The label comes off on a comment that carries the marker and comes from
rtibblesbot. The marker alone is not enough, because it is plain text that
anyone can paste.
    @akolson
    akolson committed Oct 26, 2026
    Configuration menu
    Copy the full SHA
    91b0e62 View commit details
    Browse the repository at this point in the history

  2. Sweep a stuck issue review label 

    If the agent never answers, the label stays on and tells a maintainer
nothing. The weekly run now clears a label older than
ISSUE_REVIEW_MAX_DAYS.

The sweep lives in its own module because unassign-inactive-issues skips
every issue with no assignees, and an issue under review normally has none.
    @akolson
    akolson committed Oct 26, 2026
    Configuration menu
    Copy the full SHA
    30c7939 View commit details
    Browse the repository at this point in the history

  3. Document the issue validation automations

    @akolson
    akolson committed Oct 26, 2026
    Configuration menu
    Copy the full SHA
    6add369 View commit details
    Browse the repository at this point in the history

  4. Format the issue review sweep files 

    The pre-commit hooks did not run when 30c7939 landed, so prettier wanted
these two files reformatted.
    @akolson
    akolson committed Oct 26, 2026
    Configuration menu
    Copy the full SHA
    f46ced7 View commit details
    Browse the repository at this point in the history

  5. Cover the contributor gate with tests 

    The contributor, core member and bot cases decide which issues reach the new
validation automation, and nothing tested them. The gate is shared by six
leaves, so these tests cover all of them.
    @akolson
    akolson committed Oct 26, 2026
    Configuration menu
    Copy the full SHA
    a0bebeb View commit details
    Browse the repository at this point in the history

  6. Reword the issue validation automation docs

    @akolson
    akolson committed Oct 26, 2026
    Configuration menu
    Copy the full SHA
    30f6647 View commit details
    Browse the repository at this point in the history

  7. Fix three findings from the local review 

    morango takes contributions from time to time, so validation must reach it.
COMMUNITY_REPOS is an alias of PR_STATS_REPOS, so morango also joins the
weekly statistics report and the cross-repo assignment count.

The gate now reads ISSUE_VALIDATION_REPOS, which adds test-actions. The old
gate did not name it, so the automation could not be tested where every
other one is tested.

The label job now tests the author and the marker in its condition, as
resolve-bot-pr-threads does. Every comment in every consumer used to
generate a token, check out this repo and install dependencies before the
script returned.
    @akolson
    akolson committed Oct 26, 2026
    Configuration menu
    Copy the full SHA
    a2e3230 View commit details
    Browse the repository at this point in the history

  8. Close two test gaps in the sweep and drop a duplicate 

    The sweep's fake listing ignored the label filter, so removing that filter
failed no test. Without it the sweep reads an old labeled event on an issue
whose label is already gone, gets a 404 from the removal, and reports
clearing a label the issue never had.

The fake removal always succeeded, so a failed removal was untested.

The bot-account case took the same branch as the contributor case, so it
guarded nothing.
    @akolson
    akolson committed Oct 26, 2026
    Configuration menu
    Copy the full SHA
    625368c View commit details
    Browse the repository at this point in the history
Loading