← 输入框|github.com|刷新
Skip to content

Warn on invalid savefig keyword arguments - #17223

Merged
QuLogic merged 4 commits into
matplotlib:masterfrom
QuLogic:savefig-extra-kwargs
Jun 15, 2020
Merged

Warn on invalid savefig keyword arguments#17223
QuLogic merged 4 commits into
matplotlib:masterfrom
QuLogic:savefig-extra-kwargs

Conversation

@QuLogic

@QuLogic QuLogic commented Apr 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

This depends on #17221 and #17233 so that there are no warnings about metadata from saving SVG or PDF with the PGF backend.

Fixes #192.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, … status: waiting for other PR labels Apr 23, 2020
@QuLogic
QuLogic force-pushed the savefig-extra-kwargs branch from 0bd3491 to cb47539 Compare April 23, 2020 06:02
@QuLogic
QuLogic force-pushed the savefig-extra-kwargs branch from cb47539 to f74575c Compare June 10, 2020 19:09
@QuLogic
QuLogic marked this pull request as ready for review June 10, 2020 19:13
@QuLogic

QuLogic commented Jun 10, 2020

Copy link
Copy Markdown
Member Author

Now ready, as the metadata PRs went in.

@tacaswell tacaswell added this to the v3.3.0 milestone Jun 10, 2020
anntzer
anntzer reviewed Jun 11, 2020
View reviewed changes
Comment thread lib/matplotlib/backends/backend_agg.py Resolved
anntzer
anntzer reviewed Jun 11, 2020
View reviewed changes
Comment thread lib/matplotlib/backend_bases.py Resolved
@QuLogic
QuLogic force-pushed the savefig-extra-kwargs branch from f74575c to f25f1eb Compare June 12, 2020 01:02
@QuLogic

QuLogic commented Jun 12, 2020

Copy link
Copy Markdown
Member Author

I changed it into a decorator, as @anntzer requested. I wonder if also args should be removed from the final methods?

@QuLogic
QuLogic force-pushed the savefig-extra-kwargs branch from f25f1eb to b7a574f Compare June 12, 2020 01:24
@anntzer

anntzer commented Jun 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Also removing args seems good to me?

@anntzer

anntzer commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

postci

@QuLogic
QuLogic merged commit 7b76234 into matplotlib:master Jun 15, 2020
@QuLogic
QuLogic deleted the savefig-extra-kwargs branch June 15, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes
@anntzer anntzer anntzer approved these changes

Assignees

No one assigned

Labels

API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, …

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

Savefig does not issue a warning on a non-existent keyword n

3 participants

@QuLogic @anntzer @tacaswell