Repository navigation
Bugfix/legend windowcall - #32
Merged
1 commit merged intoMar 7, 2011
Merged
1 commit merged into
1 commit merged into
Conversation
…ent with everyone else's get_window_extent()'s call signature.
Member
|
Looks good to me. |
Member
Author
|
Ok, so how do I do this properly? I haven't tried doing a merge into v1.0.x and then into master. |
Member
|
Not sure. I think Darren should know (and there are plans to add these instructions to the developer docs eventually) |
Member
|
First make sure your v1.0.x branch is fresh: (This assumes an "upstream" remote pointing to If everything is fine, push: Next do the same with master, this time merging v1.0.x: I'll post these instructions on the developer list so people can comment on them. |
Closed
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the legend object's get_window_extent() call signature to match everyone else's get_window_extent() call signature. This will allow for legend() to be passed into bbox_extra_artists kwarg for savefig().