Repository navigation
Bugfix/qt4 savefile - #33
Merged
1 commit merged intoMar 8, 2011
Merged
1 commit merged into
1 commit merged into
Conversation
Note that the API for getSaveFileName is dependent upon which version of PyQt4 you have and requires a conditional selection of the appropriate function call.
Contributor
|
I tested this with python-2.7 by doing the following: and then clicking the save button on the toolbar. Without your patch, an error is raised. With the patch, it worked as desired. I think it is ok to merge. |
Closed
fariza
added a commit
to fariza/matplotlib
that referenced
this pull request
Sep 22, 2016
report compatible python2.7 Simplification of plotting simplification of report by forcing the output directory parameter
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to support the change in the PyQt4 API of getSaveFileName(). There is now a _getSaveFileName variable that gets conditionally assigned either the old getSaveFileName method or a lambda function that wraps a call to the new getSaveFileNameAndFilter(). The lambda function was necessary so that only the filename part of the tuple returned by getSaveFileNameAndFilter() gets returned by the call to _getSaveFileName().
I have only tested the case where sip.getapi("QString") returns 1. I would greatly appreciate if others with different versions of PyQt4 test to make sure this works.