Repository navigation
Marker/scatter reconciliation - #400
Merged
Merged
Conversation
…ment Line2D-based markers in terms of it.
…rker definitions.
…. Make legend support the new kind of scatter.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set of available Line2D markers and scatter markers has always been slightly different. Some features (such as mathtext markers) were only available in one place and not the other. This refactors everything into a new markers.py module which is used from everywhere else to keep the functionality consistent and equally capable everywhere.
This seems to pass all regression tests and doesn't change any relevant examples, but it's pretty core functionality, so care should be taken it doesn't break anything.