feat(comment): Hidden comments by vicky1999 · Pull Request #9052 · microsoft/vscode-pull-request-github

Vignesh (vicky1999) · 2026-10-10T19:02:19Z

Solves #7431

Summary

whether a comment is minimized or not and the reason for minimized is available in IssueComment and PullRequestReviewComment.
Added the two fields (isMinimized, minimizedReason) to gql query and used in the component to minimize with the reason open the comment on click.
Added fold and unfold svg files from octicons to match the UI.

Demo:

Hidden.comments.mp4

Follow ups

It looks like there's a button to hide the comment with reason. It could be a follow up if it need to be added on the webview.

Copilot

🟡 Changes recommended

Expanded comment interactions currently collapse the comment, keyboard toggling is unavailable, and missing reasons render as “undefined”.

2 open findings

What changed in this PR

Adds support for displaying GitHub-minimized comments as collapsible entries with their minimization reason.

Changes:

Fetches and propagates minimization metadata.
Adds collapsible comment UI, styling, and icons.
Adds parser and component tests.

File	Description
`webviews/editorWebview/test/comment.test.tsx`	Tests minimized comment rendering.
`webviews/editorWebview/index.css`	Styles minimized comments.
`webviews/components/timeline.tsx`	Formatting-only change.
`webviews/components/icon.tsx`	Exports fold icons.
`webviews/components/comment.tsx`	Implements minimized comment UI.
`src/test/github/utils.test.ts`	Tests metadata parsing.
`src/github/utils.ts`	Propagates minimization metadata.
`src/github/queriesShared.gql`	Queries minimization fields.
`src/github/graphql.ts`	Extends GraphQL comment types.
`src/common/timelineEvent.ts`	Extends timeline comment events.
`src/common/comment.ts`	Extends shared comment data.
`resources/icons/unfold.svg`	Adds unfold icon.
`resources/icons/fold.svg`	Adds fold icon.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

🟡 Changes recommended

The new component test targets the wrong element and fails, while enum-based reasons can render with raw underscores.

1 open finding

Target minimized comment header for toggle test · New

2 resolved since last review

Previously missed (1)

In code that hasn't changed since last review

Normalize enum separators in user-facing reason labels

webviews/components/comment.tsx:91

GraphQL returns enum values such as OFF_TOPIC; lowercasing alone renders the user-facing reason as off_topic. Normalize enum separators (or map the enum to display labels) so all supported reasons are readable.

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Classifier reasons containing underscores are rendered incorrectly in the user-facing message.

0 open findings

1 resolved since last review

Target minimized comment header for toggle test

Previously missed (1)

In code that hasn't changed since last review

Normalize underscores in minimized reason

webviews/components/comment.tsx:91

minimizedReason can contain classifier values such as OFF_TOPIC (as represented by the new parser test), so lowercasing alone renders the user-facing reason as off_topic. Normalize underscores to hyphens so the message matches GitHub's “off-topic” wording.

🧠 Review effort: Balanced

Copilot

🟡 Changes recommended

Enum reasons containing underscores are rendered incorrectly in the user-facing label.

1 open finding

Normalize enum separators in user-facing GraphQL reasons · New

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Expanded minimized comments currently render an unintended nested border.

0 open findings

1 resolved since last review

Normalize enum separators in user-facing GraphQL reasons

Previously missed (1)

In code that hasn't changed since last review

Remove nested comment border in minimized issue comments

webviews/editorWebview/index.css:2265

The border: none rule is applied to .minimized-body, but that wrapper has no border; the nested .comment-container still receives the global card border from index.css:1334-1342. Expanded minimized issue comments therefore render a second bordered card inside the outer minimized-comment border. Keep the padding on the wrapper and remove the border from its direct comment child instead.

🧠 Review effort: Balanced

Copilot

🟢 Approval recommended

Static review found no blocking issues in metadata propagation, collapsible rendering, keyboard handling, or the added tests.

No open issues 🎉

_{Review effort: Balanced}

Alex Ross (alexr00)

Thanks for the PR! I think review summaries can also be hidden on GitHub, but they are not included in the new minimized feature.

Alex Ross (alexr00) · 2026-10-28T12:58:05Z

We should use the codicons for fold and unfold for these. Codicons: https://microsoft.github.io/vscode-codicons/dist/codicon.html

Alex Ross (alexr00) · 2026-10-28T12:59:30Z

These preserves tests don't seem terribly useful.

Alex Ross (alexr00) · 2026-10-28T13:00:45Z

 	const canEdit: boolean = !!(comment as Partial<IComment | PullRequest | CommentEvent>).canEdit;
 	const canDelete: boolean = !!(comment as Partial<IComment | CommentEvent>).canDelete;
+	const isMinimized: boolean = (comment as Partial<CommentEvent>).isMinimized ?? false;
+	const minimizedReason: string | undefined = (comment as Partial<CommentEvent>).minimizedReason?.toLowerCase().replace(/_/g, ' ') ?? undefined;


Does GitHub provide a human-readable value for this?

It seems like not, but instead of doing a replace like this, we should map well known slugs to nice user-facing messages.

Alex Ross (alexr00) · 2026-10-28T15:16:42Z

+	children?: React.ReactNode;
+};
+
+function MinimizedComment({ isMinimized, minimizedReason, children }: MinimizedCommentProps) {


The isMinimized prop is redundant. MinimizedComment is only rendered when it's true.

Alex Ross (alexr00) · 2026-10-28T15:17:16Z

+	return (
+		<div className="minimized-comment-container">
+			<div
+				className="minimized-comment-header"


Can we use a native button?

Alex Ross (alexr00) · 2026-10-28T15:19:03Z

 const ReviewEventView = (event: ReviewEvent) => {
 	const comments = groupCommentsByThread(event.comments);
 	const reviewIsPending = event.state === 'PENDING';
+


Unrelated change.

feat(comment): Hidden comments

26e03ae

Copilot AI balanced review requested due to automatic review settings October 10, 2026 19:02

Copilot started reviewing on behalf of Vignesh (vicky1999) October 10, 2026 19:05

View session

Copilot AI reviewed Oct 10, 2026

View reviewed changes

Comment thread webviews/components/comment.tsx Resolved

Comment thread webviews/components/comment.tsx Resolved

fix: comments

214d605

Copilot AI balanced review requested due to automatic review settings October 11, 2026 19:13

Copilot started reviewing on behalf of Vignesh (vicky1999) October 11, 2026 19:16

View session

Copilot AI reviewed Oct 11, 2026

View reviewed changes

Comment thread webviews/editorWebview/test/comment.test.tsx Resolved

fix: CommentView tests

19916b6

Copilot AI balanced review requested due to automatic review settings October 11, 2026 19:28

Copilot started reviewing on behalf of Vignesh (vicky1999) October 11, 2026 19:31

View session

Copilot AI reviewed Oct 11, 2026

View reviewed changes

Merge branch 'main' into vicky1999/7431-hidden-comments

c5abe91

Copilot AI balanced review requested due to automatic review settings October 13, 2026 18:42

Copilot started reviewing on behalf of Vignesh (vicky1999) October 13, 2026 18:45

View session

Copilot AI reviewed Oct 13, 2026

View reviewed changes

Comment thread webviews/components/comment.tsx Resolved

fix: comments on minimizedReason

af5bc57

Copilot AI balanced review requested due to automatic review settings October 14, 2026 07:10

Copilot started reviewing on behalf of Vignesh (vicky1999) October 14, 2026 07:12

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

Merge branch 'main' into vicky1999/7431-hidden-comments

1325946

Copilot AI balanced review requested due to automatic review settings October 22, 2026 15:14

Copilot started reviewing on behalf of Vignesh (vicky1999) October 22, 2026 15:17

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

Alex Ross (alexr00) requested changes Oct 28, 2026

View reviewed changes

Conversation

Vignesh (vicky1999) commented Oct 10, 2026

Summary

Demo:

Follow ups

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Alex Ross (alexr00) left a comment

Choose a reason for hiding this comment

Uh oh!

Alex Ross (alexr00) Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alex Ross (alexr00) Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

Alex Ross (alexr00) Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

Alex Ross (alexr00) Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

Alex Ross (alexr00) Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

Alex Ross (alexr00) Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

Alex Ross (alexr00) Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alex Ross (alexr00) Oct 28, 2026 •

edited

Loading