Repository navigation
Name the failing request when the pull request overview fails to load - #9126
Draft
Alex Ross (alexr00) with Copilot wants to merge 2 commits into
Draft
Alex Ross (alexr00) with Copilot wants to merge 2 commits into
Alex Ross (alexr00) with Copilot wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix transient connect timeout on GET /user breaking PR overview
Name the failing request when the pull request overview fails to load
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single transient network error (e.g.
UND_ERR_CONNECT_TIMEOUTonGET /user) used to break the PR overview until reload. The error shown,Error updating pull request description: …, also didn't say which request had failed.The two caching root causes from the issue are already fixed on
main. This PR addresses the remaining part: the error message.Already fixed on
main(unchanged here)CredentialStore.ensureCurrentUsermakes one request at a time and drops it when it fails, so the next caller retries (Retry current user request after failure #8898, Retry authenticated user lookup after transient failures #8910).GitHubRepository.getMetadataclears_metadatawhen a request fails, guarded so it can't clear a newer request. Only the deliberate "404 means skip this repository for the session" case stays cached.Changes
PullRequestOverviewPanel.updateItemNow: four loads run together (default branch, repository permissions, current user, edit permissions). The existingmeasuretiming helper now also takes a localized label, and a failure is re-thrown with that label:Error loading pull request #<n>: <operation> failed: <cause>, and it is also written to the log. Before, it was the misleadingError updating pull request description.pullRequestOverview.test.ts› "loading errors"):FolderRepositoryManager→CredentialStorepath, with a cast-free hub whose firstGET /usertimes out.GET /user, which checks the retry end to end.Notes for review
IssueOverviewPanel.updateItemstill reportsError updating issue descriptionfor a similar combined load. It's left for a follow-up to keep this PR small.