Repository navigation
Don't show a refresh error when the PR description tab closes during a refresh - #9145
Draft
Alex Ross (alexr00) with Copilot wants to merge 2 commits into
Draft
Alex Ross (alexr00) with Copilot wants to merge 2 commits into
Alex Ross (alexr00) with Copilot wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error toast when merging PR from description tab
Don't show a refresh error when the PR description tab closes during a refresh
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging from the PR description tab can show
Error refreshing pull request description: Webview is disposed. This happens when the merge closes the tab: withdeleteBranchAfterMergeand apostDonedefault-branch checkout, the checkout closes the tab.The merge fires a
statechange, and that startsrefreshPanel(). While it waits forresolveModel(...), the checkout closes the tab and the panel is disposed. When the refresh resumes,updateItemNowreadsthis._panel.visible. VS Code'sWebviewPanelgetters throwWebview is disposedafter dispose, andrefreshPanel'scatchshows that error as a toast.Changes (
PullRequestOverviewPanel)refreshPanel()_panel.visibleitself threw here, so the call rejected.isDisposedafterresolveModeland returns quietly.processPendingUpdates()createOrShow) would runupdateItemNow, hit the same throw, and make the caller's promise fail.Tests
New
refreshing a closed panelblock inpullRequestOverview.test.ts:refreshPanel()called after the tab is closed: no lookup and no error.createOrShowdoesn't fail.To support these, the
createPanelfixture now also returnswebviewPaneland the default-branch stub.