Repository navigation
[Tests] Stop php -S servers together with their forked workers - #658
Merged
chr-hertel merged 1 commit intoNov 3, 2026
Merged
Conversation
ruudk
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 3, 2026 11:59
chr-hertel
requested changes
Nov 3, 2026
chr-hertel
left a comment
Member
There was a problem hiding this comment.
Thanks @ruudk - good one, could you please streamline the other cases as well?
- tests/Integration/HttpNegotiationTest.php:48
- tests/Integration/StatelessClientTest.php:67
- tests/Integration/StatelessLifecycleTest.php:58
- tests/Interop/Server/Http/HttpInspectorSnapshotTestCase.php:73
Stopping the php -S process only ended the master. With PHP_CLI_SERVER_WORKERS the workers were reparented, kept their port and the inherited stdout/stderr, so `make integration-tests | tail` never saw EOF. Stop every php -S server the tests start through ServerProcess::stop(), which ends the whole process tree.
ruudk
force-pushed
the
fix/stop-php-server-workers
branch
from
November 3, 2026 13:39
6117756 to
f3b98c1
Compare
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping a
php -Sprocess only ended the master, so itsPHP_CLI_SERVER_WORKERSwere reparented and kept the port and the inherited stdout/stderr open, which mademake integration-tests | tailhang after the suite finished. Every test that starts aphp -Sserver now stops it throughServerProcess::stop(), which ends the whole process tree.