← 输入框|github.com|刷新
Skip to content

doc: correct buffer pool allocation threshold - #67247

Open
adityareddy-dev wants to merge 1 commit into
nodejs:mainfrom
adityareddy-dev:doc/buffer-pool-threshold
Open

adityareddy-dev wants to merge 1 commit into
nodejs:mainfrom
adityareddy-dev:doc/buffer-pool-threshold

Conversation

@adityareddy-dev

Copy link
Copy Markdown

The Buffer docs include the half-pool boundary in two allocation descriptions, but allocations at that size don't use the pool. I changed both to the strict Buffer.poolSize >>> 1 threshold used by the implementation.

Refs: #67235

Signed-off-by: Aditya Reddy <82123567+adityareddy-dev@users.noreply.github.com>
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation. labels Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

@MikeMcC399

Copy link
Copy Markdown
Contributor

The recommendations in:

advise you should tackle only one issue at a time and that you should not open any new PRs until your first PR has been approved.

You have multiple unapproved PRs open at this time.

Until the first PR has been approved and has landed in the main branch, GitHub classifies you as "first-time contributor". Each PR commit you push needs to be individually approved by team members to run in GitHub Actions CI. This causes delays for you as a contributor, and it adds to the work load for the team.

Waiting until the first PR has landed ensures that you as a contributor have experienced the complete process from PR submission to successful landing. After this has been completed, any new PRs or new commits to an existing PR are treated to rules for regular Contributors. GitHub Actions CI workflows are then run automatically without intervention by a team member.

@adityareddy-dev

Copy link
Copy Markdown
Author

Thanks Mike, that makes sense. Closing this one for now and keeping #67243 open until it lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:automated-account buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants