Repository navigation
[Fix #1740] Forcing cache reload in test - #1741
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new abstract lifecycle method breaks compatibility with existing HashFactory implementations.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds coverage for reloading hash mappings after clearing the in-memory cache.
Changes:
- Makes hash factories closeable and clears cached mappings on close.
- Connects the test’s hash factory to MVStore and forces a cache reload.
- Closes hash factories with MVStore resources.
| File | Description |
|---|---|
AbstractHandlerPersistenceTest.java |
Clears the cache before re-reading persisted data. |
MVStorePersistenceStoreTest.java |
Shares the test hash factory with MVStore. |
MVStorePersistenceStore.java |
Closes its hash factory. |
HashFactory.java |
Adds AutoCloseable lifecycle support. |
DefaultHashFactory.java |
Clears cached mappings on close. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
ricardozanini
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1740