Repository navigation
Fix a few false positives from the analyzer - #3063
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Phpactor Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 51d53fa | Previous: 7eb622f | Ratio |
|---|---|---|---|
ConfigLoaderBench::benchJsonLoadConfig |
0.03125960861056772 ms (± 1.03%) |
0.015278043052837505 ms (± 2.70%) |
2.05 |
ConfigLoaderBench::benchJsonPlainPhp |
0.018384422700586954 ms (± 1.76%) |
0.007512211350293557 ms (± 3.28%) |
2.45 |
This comment was automatically generated by workflow using github-action-benchmark.
dantleech
approved these changes
Aug 15, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issues where found by running https://zonuexe.github.io/php-typing-conformance/ on the latest master branch. It was actually already the LSP (including qodana) with the least false positives with just 4 failing cases. If you could make a release after merging this I would like to submit a PR to the project so that it can be automatically checked going forward.