Repository navigation
Limit associative array cast checks to matching keys - #6578
Merged
ondrejmirtes merged 1 commit intoNov 1, 2026
Merged
Conversation
midhunmonachan
force-pushed
the
fix-array-diff-assoc-key-overlap
branch
from
September 24, 2026 17:55
5072c0f to
fd968ae
Compare
midhunmonachan
force-pushed
the
fix-array-diff-assoc-key-overlap
branch
from
September 24, 2026 18:08
fd968ae to
b9efac7
Compare
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array_diff_assoc()andarray_intersect_assoc()only compare values when their keys can match. PHPStan was checking every value and could report on unrelated non-stringable values.This narrows the castability check to values under overlapping keys and adds a regression test for the reported case while keeping errors for shared non-stringable values.
Closes phpstan/phpstan#15261
Checks:
bin/phpstan -vThe current 2.3.x base also has a pre-existing Turbo version-pin check failure after commit
17972fe; this PR does not touchturbo-ext.