← 输入框|github.com|刷新
Skip to content

Add support for connection #25

Closed
Closed

Description

@joneshf

The node.js http module has had support for request.connection for ages (since version 0.3.0), it's just been poorly documented. Up until the 8.x series it was tucked away in the comment of the 'connection' event. Since then, it's had its own documentation. I'd like to propose we add support for connection, but it will require some work for the Socket it returns.

My guess (and what I mentioned on slack) is that we'll want a purescript-node/purescript-node-net package, where we have Socket and all its facilities defined. If that's the case, I'm more than happy to do the work if someone can make the repo. Then, we can expose connection :: Node.HTTP.Request -> Node.Net.Socket. Does that sound about right?

Activity

  1. hdgarrood commented on Apr 26, 2019

    @hdgarrood
    Member

    Sounds good to me. I guess we don’t yet have bindings for net.Server either?

  2. hdgarrood commented on May 7, 2019

    @hdgarrood
    Member
  3. joneshf commented on May 7, 2019

    @joneshf
    Author

    Thanks!

  4. garyb commented on May 7, 2019

    @garyb
    Member

    I invited you to be an admin of the org a while back actually, did that ever come through?

  5. joneshf commented on May 7, 2019

    @joneshf
    Author

    Yeah, I accepted that as well (I'm just slow 😊). Thanks!

  6. JordanMartinez commented on Aug 1, 2023

    @JordanMartinez
    Contributor

    Fixed by #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions