← 输入框|github.com|刷新
Skip to content

Fix encoding - #9

Merged
thomashoneyman merged 4 commits into
purescript-node:masterfrom
i-am-the-slime:patch-1
Apr 1, 2021
Merged

Fix encoding#9
thomashoneyman merged 4 commits into
purescript-node:masterfrom
i-am-the-slime:patch-1

Conversation

@i-am-the-slime

@i-am-the-slime i-am-the-slime commented Mar 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of the change

Turns the PureScript Encoding type into the correct string that nodejs expects.

This avoids the following error.

TypeError [ERR_UNKNOWN_ENCODING]: Unknown encoding: UTF8 {}

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

hdgarrood
hdgarrood approved these changes Mar 18, 2021
View reviewed changes

@hdgarrood hdgarrood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

thomashoneyman
thomashoneyman approved these changes Mar 18, 2021
View reviewed changes

@thomashoneyman thomashoneyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @i-am-the-slime! Can you please add this to the changelog?

@i-am-the-slime
Fix encoding
b4efc12 
Otherwise I get:
```
TypeError [ERR_UNKNOWN_ENCODING]: Unknown encoding: UTF8 {}
```
@i-am-the-slime

i-am-the-slime commented Mar 20, 2021

Copy link
Copy Markdown
Contributor Author

@thomashoneyman I wrote a sentence. I hope it's more or less understandable.

@thomashoneyman
thomashoneyman merged commit 15adf15 into purescript-node:master Apr 1, 2021
@thomashoneyman

thomashoneyman commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

https://github.com/purescript-node/purescript-node-net/releases/tag/v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hdgarrood hdgarrood hdgarrood approved these changes
@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@i-am-the-slime @thomashoneyman @hdgarrood