Repository navigation
"CPython implementation detail:" removed when content translated #72518
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2017-03-22.12:10:05.688>
created_at = <Date 2016-10-01.13:29:12.357>
labels = ['type-feature', '3.7', 'docs']
title = '"CPython implementation detail:" removed when content translated'
updated_at = <Date 2017-03-24.22:41:36.817>
user = 'https://github.com/methane'bugs.python.org fields:
activity = <Date 2017-03-24.22:41:36.817>
actor = 'methane'
assignee = 'docs@python'
closed = True
closed_date = <Date 2017-03-22.12:10:05.688>
closer = 'methane'
components = ['Documentation']
creation = <Date 2016-10-01.13:29:12.357>
creator = 'methane'
dependencies = []
files = ['44910', '44969']
hgrepos = []
issue_num = 28331
keywords = ['patch']
message_count = 8.0
messages = ['277817', '278106', '278107', '278108', '278111', '278272', '290098', '290266']
nosy_count = 7.0
nosy_names = ['georg.brandl', 'terry.reedy', 'methane', 'docs@python', 'berker.peksag', 'JulienPalard', 'Julien.Palard']
pr_nums = ['195', '769']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue28331'
versions = ['Python 3.6', 'Python 3.7']
Activity
methane commentedon Oct 1, 2016
"CPython implementation detail:" label is removed when contents of impl-detail directive is translated.
This is very bad for people reading translated documents.
Attached patch fixes this, with enabling translating the label, like versionchanged directive.
berkerpeksag commentedon Oct 5, 2016
Does Sphinx use a dummy HTML file like you did in the patch?
methane commentedon Oct 5, 2016
Yes. Actually speaking, this patch is almost copy from VersionChanged directive.
See here:
https://github.com/sphinx-doc/sphinx/blob/master/sphinx/directives/other.py#L216-L221
berkerpeksag commentedon Oct 5, 2016
I couldn't find any dummy HTML in the Sphinx codebase.
Wouldn't something like work without a dummy HTML?
Then use it in ImplementationDetail.run() method like https://github.com/sphinx-doc/sphinx/blob/master/sphinx/directives/other.py#L204
methane commentedon Oct 5, 2016
Ah, I misunderstood your comment is about Sphinx's internal DOM.
Sphinx has own pot and po files.
In case of custom extension,
sphinx-build -b gettextdoesn't extractmessages from Python code. That's why I used dummy html template.
Another way is adding custom make target, which runs
sphinx-build -b gettextand custom command to generate another pot from pyspecific extension.
terryjreedy commentedon Oct 7, 2016
I abbreviated title to make most of it visible in listings.
[-]"CPython implementation detail:" is removed when contents is translated[/-][+]"CPython implementation detail:" removed when content translated[/+]methane commentedon Mar 24, 2017
New changeset 906118d by INADA Naoki in branch '3.6':
bpo-28331: fix impl-detail label is removed when content is translated. (GH-769)
906118d
methane commentedon Mar 24, 2017
New changeset c351ce6 by INADA Naoki in branch 'master':
bpo-28331: fix impl-detail label is removed when content is translated. (GH-195)
c351ce6