Repository navigation
[sqlite3] Clean up function scoping #87435
Description
| BPO | 43269 |
|---|---|
| Nosy | @berkerpeksag, @erlend-aasland |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-02-21.10:08:29.876>
created_at = <Date 2021-02-19.12:05:57.154>
labels = ['type-feature', 'library', '3.10']
title = '[sqlite3] Clean up function scoping'
updated_at = <Date 2021-02-21.10:08:29.876>
user = 'https://github.com/erlend-aasland'bugs.python.org fields:
activity = <Date 2021-02-21.10:08:29.876>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2021-02-21.10:08:29.876>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2021-02-19.12:05:57.154>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 43269
keywords = ['patch']
message_count = 5.0
messages = ['387310', '387314', '387432', '387441', '387449']
nosy_count = 2.0
nosy_names = ['berker.peksag', 'erlendaasland']
pr_nums = ['24578', '24605']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue43269'
versions = ['Python 3.10']
Activity
erlend-aasland commentedon Feb 19, 2021
There's a lot of file scoped functions without the static storage-class specifier. All file local functions should have the static storage-class specifier.
erlend-aasland commentedon Feb 19, 2021
Ref. #24569 (comment), Berker.
berkerpeksag commentedon Feb 21, 2021
New changeset bf838a6 by Erlend Egeberg Aasland in branch 'master':
bpo-43269: Clean up sqlite3 file scope (GH-24578)
bf838a6
erlend-aasland commentedon Feb 21, 2021
Serhiy also mentioned that marking functions definitions with the extern keyword is not very common in the CPython source base. #24578 (comment)
I suggest cleaning up those as well, while we're at it.
berkerpeksag commentedon Feb 21, 2021
New changeset 38b6c2a by Erlend Egeberg Aasland in branch 'master':
bpo-43269: Remove redundant extern keywords (GH-24605)
38b6c2a