Repository navigation
gh-120161: Clean Up the Managed Static Types State - #120663
Closed
ericsnowcurrently wants to merge 8 commits into
Closed
ericsnowcurrently wants to merge 8 commits into
ericsnowcurrently wants to merge 8 commits into
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
|
This PR is attached to gh-120161, which is already completed: the fix for that issue landed through other changes, and this PR's approach was not taken or has since become obsolete. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In gh-120182, the approach I took aimed to fix the problem with minimal churn, for the sake of backporting. This change builds on that with what I consider the cleaner approach I would have taken.
The key changes are:
Objects/typeobject.c:143: managed_static_type_index_get: Assertionmanaged_static_type_index_is_set(self)' failed.` in 3.13.0b2+, with freezegun #120161