Repository navigation
bpo-36972: Add SupportsIndex - #13448
Merged
Merged
Conversation
auvipy
approved these changes
May 20, 2019
Contributor
|
The |
Member
|
I'm sorry, I don't have time to review this. |
Contributor
Author
|
There is an internal _SupportsIndex in typeshed, and the PR that introduced it (python/typeshed#2996) can easily be tweaked to use this implementation to support runtime checking. |
ilevkivskyi
reviewed
May 21, 2019
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Thanks! This looks like a reasonable addition, I have just couple minor comments.
Update typing docs, adjust blurb.
|
Member
|
The failure looks unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support typing checks calling
hex()oct()andbin()on user-defined classes, a SupportIndex protocol is required. The ability to check these at runtime would be good to add for completeness sake. This is pretty much just a copy of SupportsInt with the names tweaked. Passed tests on my laptop.https://bugs.python.org/issue36972