Repository navigation
Doc: Fix allocator mismatch in PyStatus example - #160757
Merged
Merged
Conversation
Documentation build overview
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused correction matches the allocator contract and leaves no unresolved review findings.
No open issues 🎉
What changed in this PR
This PR corrects the allocator pairing in the C API documentation’s PyStatus example.
Changes:
- Replaces
PyMem_Free(ptr)withPyMem_RawFree(ptr)to match the allocation API used by the example.
| File | Description |
|---|---|
Doc/c-api/init_config.rst |
Corrects the deallocation call in the PyStatus example. |
Review effort: Balanced
StanFromIreland
approved these changes
Oct 27, 2026
PyStatus example
vstinner
approved these changes
Oct 27, 2026
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. It's good that at least one person read the doc that I wrote long time ago 😅
|
Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160797 is a backport of this pull request to the 3.15 branch. |
|
GH-160798 is a backport of this pull request to the 3.14 branch. |
methane
added a commit
that referenced
this pull request
Oct 28, 2026
methane
added a commit
that referenced
this pull request
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.