Repository navigation
gh-160761: Fix TypeError when pickling directly instantiated urllib.parse result objects - #160762
Open
austinaviv wants to merge 1 commit into
Open
austinaviv wants to merge 1 commit into
austinaviv wants to merge 1 commit into
Conversation
…llib.parse result objects
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-160761
When URL result objects (
SplitResult,ParseResult,DefragResult, etc.) are instantiated directly rather than returned fromurlsplit()orurlparse(), their_keep_emptyattribute is not set.In this case,
super().__getstate__()returnsNone._ResultBase.__getstate__()attempted to subscriptstate[1], causingTypeError: 'NoneType' object is not subscriptable.This change checks if
state is not Nonebefore accessingstate[1], and adds tests verifying that all result types can be pickled when created directly.