Repository navigation
gh-160766: Handle nested annotated and generic aliases that contain forward references in annotations - #160769
Open
DavidCEllis wants to merge 3 commits into
Open
DavidCEllis wants to merge 3 commits into
DavidCEllis wants to merge 3 commits into
Conversation
Special case name replacement to render correct strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds another special case to
_Stringifier.__convert_to_astto handletypes.GenericAliasandtyping.Annotatedsimilar to the handling of list, set, tuple, dict that constructs the ast to rebuild theGenericAliasorAnnotatedobject.This is to prevent the
ForwardRefobjects from becoming "hidden" inside theGenericAliasorAnnotatedobjects.For
GenericAliasanast.Callnode is created to reconstruct theGenericAliasas there's no guarantee it was created through subscripting. The call is converted back to subscript format when evaluating theForwardRefinSTRINGformat in order to match the repr ofGenericAliasobjects.For
Annotated, subscripting is used. Are there any other types that need to be handled?Main:
PR:
ForwardRef.evaluate#160766