Repository navigation
Conversation
Move filter.__new__ to Argument Clinic with @vectorcall, dropping the hand-written filter_new and filter_vectorcall. The generated vectorcall name matches the hand-written one so the tp_vectorcall slot is unchanged, and argument error messages are unchanged on both paths. pyperf microbenchmark (PGO+LTO, run serially), no significant change on the vectorcall path: | Benchmark | base | filter | |---------------------|:-------:|:---------------------:| | `filter.__new__` | 45.4 ns | 42.7 ns: 1.06x faster | | filter(bool, list) | 32.3 ns | 32.8 ns: 1.01x slower | | filter(None, range) | 30.6 ns | 31.8 ns: 1.04x slower | | Geometric mean | (ref) | 1.01x faster | Benchmark hidden because not significant (3): subclass(None, tuple), filter(None, tuple), list(filter(None, list)) filter.__new__ drops PyArg_UnpackTuple for inline clinic parsing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
filter.__new__to Argument Clinic with @vectorcall, dropping the hand-writtenfilter_newandfilter_vectorcall. The performance delta is within noise on my machine.pyperf microbenchmark (PGO+LTO, run serially), no significant change on the vectorcall path:
filter.__new__Benchmark hidden because not significant (3): subclass(None, tuple), filter(None, tuple), list(filter(None, list))