This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Changing backend for audio loading #220
Description
Currently scipy.io.wavfile is being used for loading of the wav files. Alternatively pysoundfile could be used. It would allow for:
- 24-bit audio support
- much more audio file formats such as FLAC
It's a relatively easy change - happy to contribute it if you agree with it.
Reacted by Fabian-Robert Stöter, Felipe Raimann and Thomas Fillon
Reacted by Fabian-Robert Stöter
Activity
rudrathegreat commentedon Jan 5, 2019
Many people use
scipy.io.wavfledue to the fact that it is widely used by many developers and that if you do however find weird errors, there is a lot of material on it, compared to other libraries likepysoundfile.And moreover, the original module itself contains the basic necessities for saving and reading wave-files. However, the reason why you mentioned that
pysoundfilewould be a good alternative is because it can deal with other wave-file formats which is sometimes unnecessary. But if a developer needs that speciality, then he would certainly turn towards this lib.felipeacsi commentedon Jan 16, 2019
This is a good idea. I'm in need of implement this so my code would be simpler and I don't need to convert to wav from flac.
soundfileis a great package and its developers are always answering issues on its repo if someone eventually have a problem.I think though that we should implement this having
soundfileas an optional dependency. @adrian-stepien can I work on that taking your previous work on #221? or do you prefer to do it? Let me know what do you think.rudrathegreat commentedon Jan 17, 2019
My best way to go is to work with @adrian-stepien as I am still a kid. If you would like an example of a program using 'scipy', then you can check out my gist (link below) -
https://gist.github.com/rudrathegreat/e1655b641aae0aedb6837f83493e6e5d
https://gist.github.com/rudrathegreat/8470ad7b8ca6c6067214a3fa4f9980a3
If you do need any help, then I will always be ready to assist you guys.
felipeacsi commentedon Jan 17, 2019
Thanks for the links. In this project we also work with scipy for audio I/O, so there is no problem with that.
Let's see if someone else have anything to add. Maybe next week I can do all the tweaks to have this working.
rudrathegreat commentedon Jan 18, 2019
Cool
adrian-stepien commentedon Feb 10, 2019
I am more than happy to finalise the #221. I've been away for past month, so will work on that now.