Add support for clarity processing #121

Activity

1. mickp commented on Nov 27, 2019

   

   mickp

   on Nov 27, 2019

   CollaboratorAuthor

   More actions

   Work in progress
2. iandobbie commented on Nov 6, 2020

   

   iandobbie

   on Nov 6, 2020

   Collaborator

   More actions

   Danny worked on integrating this properly on the engineering system. His current version is at https://github.com/dstoychev/microscope/tree/aurox

   There is however an outstanding issue:

   There is still the issue of the clarity_processor modules
   (https://github.com/pptman/clarity_processor). Because they are not
   packaged it is difficult to use them. I see several options going
   forward:

   1. Create a PR to add setup.py and whatever else is necessary to make
      it a proper package.
   2. Create a fork in MicronOxford and modify it however we want.
   3. Add a new config option for the Clarity device that specifies a
      path to clarity_process.py, then load the module dynamically with
      importlib.util.
   4. Don't do anything. Leave it to the the user to setup the
      clarity_process module.

   Do you have any preferences? I like the first two options the best and
   I am happy to talk to Mark Neil about it.

   Can we please solve this issue and get the working version of the clarity processing into the main branch.