Repository navigation
revert: remove short verbatim prose caught by the whole unit audit - #1858
Merged
Merged
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1858 +/- ##
==========================================
+ Coverage 99.30% 99.87% +0.56%
==========================================
Files 33 33
Lines 3882 3882
Branches 567 567
==========================================
+ Hits 3855 3877 +22
+ Misses 18 3 -15
+ Partials 9 2 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eighth removal pass for #1835. An exact whole unit comparison with no length floor caught the two to four word docstrings every earlier threshold sat above: A DNS entry, String representation (four copies), Name accessor, Adds an entry, Removes an entry, Unregister a service, Removes a listener, the Some timing constants and Some DNS constants comments, and the packets docstring whose first line edits the 2009 original and still carried an orphaned fragment of it. Multi line docstrings whose first line was 2009 text are deleted whole.
Run alongside it, an arrangement audit compared class order and per class method order against the 2009 and 2014 monoliths and found no ordering with even 0.6 similarity, so the arrangement concern noted in the original audit no longer applies to the current tree.
Deletion only, suite green; the follow up restores fresh text.
Test plan