Repository navigation
revert: remove the modernized port of the 2009 test suite - #1865
Merged
Merged
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1865 +/- ##
==========================================
- Coverage 99.87% 99.81% -0.06%
==========================================
Files 33 33
Lines 3882 3882
Branches 567 567
==========================================
- Hits 3877 3875 -2
- Misses 3 4 +1
- Partials 2 3 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Twelfth removal pass for #1835, from an independent adversarial audit of the removal claims. Paul's 2009 ZeroconfTest.py survived as a mechanically modernized port that blame lost at the 2021 test split: eleven methods across test_init, test_protocol and test_core keep the 2009 method sequence, fixtures and assertions with only camelCase and API renames, at AST structure ratios up to 0.87. All eleven are deleted whole here.
The follow up rewrites the same coverage as freshly authored bare pytest functions, converts the surviving class based tests in those files to bare functions, which also retires the 2009 class names, and replaces the 2009 descended fixture values used across the suite.
Test plan