Repository navigation
chore: order classes and methods by the repo convention - #1867
Merged
Merged
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase |
bdraco
force-pushed
the
reorder_to_convention
branch
from
August 29, 2026 21:44
e3cc4b2 to
603bb6a
Compare
1 task done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1867 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3882 3882
Branches 567 567
=======================================
Hits 3877 3877
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bdraco
marked this pull request as ready for review
August 29, 2026 21:46
This was referenced Aug 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the ordering item from the independent audit for #1835 so it never becomes a counsel question. Class bodies across
_dns.py,_protocol/outgoing.pyand_exceptions.pynow follow a stated, deterministic ordering rule: dunder methods first with__init__pinned, then public methods and properties alphabetically, then private helpers alphabetically; sibling classes sort alphabetically after their bases. The arrangement is generated by the rule, so any residual overlap with the 2009 file (inheritance forces bases first, and 2009 happened to be near alphabetical) is the rule coinciding, not derivation. Measured ordering similarity drops from 0.80 to 0.56 forDNSRecordand 0.60 to 0.29 forDNSOutgoing, and the 2009 contiguous class run is broken.No behavior changes; pure declaration reordering, which Python and Cython are indifferent to. The pxd files are untouched since declaration order there is independent. Package metadata moved to its own PR.
Test plan