Repository navigation
chore: add an add_question_batch helper for the packet count tests - #1882
Merged
Merged
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase |
bdraco
force-pushed
the
replace_testname_stragglers
branch
from
August 29, 2026 23:05
aaead8d to
3f26b5a
Compare
bdraco
force-pushed
the
question_batch_helper
branch
from
August 29, 2026 23:05
307c268 to
0d81a97
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1882 +/- ##
==========================================
+ Coverage 99.79% 99.87% +0.07%
==========================================
Files 33 33
Lines 3882 3882
Branches 567 567
==========================================
+ Hits 3874 3877 +3
+ Misses 4 3 -1
+ Partials 4 2 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bdraco
force-pushed
the
question_batch_helper
branch
from
August 29, 2026 23:09
0d81a97 to
0bb2076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #1881. The build N questions loops in the packet count tests collapse into an add_question_batch helper in the tests package; the helper documents that the default stem must stay eight characters because the packet count assertions depend on the encoded name length, which is exactly the coupling that made #1881 subtle.
Test plan