Repository navigation
chore: rework the remaining echoes flagged by the seventh independent audit - #1890
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you agree that this new contribution is offered under Apache 2.0. This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work. If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1890 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3911 3911
Branches 568 568
=======================================
Hits 3906 3906
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Follow-up to the seventh independent audit of the #1835 removal claims, which reproduced every number in the issue and surfaced three remaining echoes: the readme fork note quoting the 2009 project description phrase, the launch and close test family, and one docstring still scoring against removed text.
Details
test_launch_and_close_*functions kept the 2009 test family's naming stem, and the unicast variant kept the 2009 body shape with a flag added. They fold into parametrized tests with fresh names:test_open_and_close_cleanlygains a unicast axis, the context manager test is parametrized over interfaces, the two IPv6 warning tests merge into one parametrized function, and thervlocals are renamed.RecordManager's class docstring measured 0.67 against a removed 2009 descended line; reworded.Test plan
REQUIRE_CYTHON=1rebuild: 518 passed