Repository navigation
Preserve Wang terrain classes when loading JSON tilesets - #91
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
AI-assisted implementation and testing with OpenAI Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a JSON tileset silently drops the optional class fields on Wang sets and colors. The same fields already load correctly from TSX, and both public model classes already expose class_. This leaves applications with different terrain metadata depending on export format.
Copy the optional class fields using the same behavior as the TMX parser, including explicit empty strings. The terrain type field (corner/edge/mixed) remains separate.
The integration tests load complete JSON/TSX tilesets through parse_tileset(), covering independent set/color classes, omitted fields and empty strings, while checking properties and Wang IDs. Original source: 6 failures and 8 controls passing; fixed: all 14 cases pass.
Validation on macOS/Python 3.14:
Tiled documents both optional class fields: https://doc.mapeditor.org/en/stable/reference/json-map-format/#wang-set
AI assistance was used to identify, reproduce, implement and test this fix. This is a code-inspection finding; no production incident is claimed.