← 输入框|github.com|刷新
Skip to content

TryComputeClrArgumentType doesn't do anything #2474

Open

Description

@twastvedt

Type? clrtype = null;
if (clrtype != null)

Was stepping through the code trying to debug something (I think) unrelated, and noticed that TryComputeClrArgumentType always skips its contents. Is that intended?

Activity

  1. lostmsu commented on Oct 4, 2024

    @lostmsu
    Member

    It may be dead code, but most certainly is not intended.

  2. changed the title [-]TryComputeClrArgumentType doesn't do anything. Intended?[/-] [+]TryComputeClrArgumentType doesn't do anything[/+] on Oct 7, 2024
  3. filmor commented on Oct 27, 2024

    @filmor
    Member

    @lostmsu This is the relevant PR: #1531, a fix for #1523

    It has been like this for all v3 releases.

  4. lostmsu commented on Oct 28, 2024

    @lostmsu
    Member

    @filmor and we've got no major complains about parameter type resolution. I think it can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions