Repository navigation
Add run tests action - #3221
Merged
Merged
Add run tests action#3221
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 1c96bbe. Configure here.
dariaguy
marked this pull request as draft
April 5, 2026 14:33
Collaborator
|
Hi @dariaguy, thanks for the PR. Can you explain why this is needed? |
dariaguy
marked this pull request as ready for review
April 6, 2026 14:42
nkaradzhov
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created
run-testsaction in order to run node-redis tests from another repo and editedtestsworkflow to use the new actionChecklist
npm testpass with this change (including linting)?Note
Low Risk
Low risk: only refactors CI by moving existing test/build/upload steps into a composite action; main risk is workflow misconfiguration breaking test runs.
Overview
Refactors the
TestsGitHub Actions workflow to call a new reusable composite action (.github/actions/run-tests) instead of inlining the Node setup/build/test/Codecov upload steps.The new action parameterizes Node version, Redis tag/version, optional repository/ref checkout, optional Codecov upload, and gated OTEL metrics reporting via an input token.
Reviewed by Cursor Bugbot for commit 1b76e10. Bugbot is set up for automated code reviews on this repo. Configure here.