Repository navigation
ci: replace brittle Codecov uploader with codecov-action - #3314
Merged
Merged
Conversation
The "Upload to Codecov" step manually fetched Codecov's PGP key from keybase.io with a bare curl, then verified and ran the standalone uploader. keybase.io is a deprecated/unreliable key source; when it serves non-key content the gpg import returns non-zero and the whole step exits 2, reddening otherwise-green builds. The root cause is now confirmed upstream: codecov-action v7.0.0 notes that the `codecovsecurity` keybase account was deleted (migration issues) and replaced with `codecovsecops`. The inlined step verified against the now-deleted account, so it could never succeed. Swap the manual block for codecov/codecov-action@v7, which handles key verification and retries internally against the current account. fail_ci_if_error: false preserves the prior best-effort intent — a coverage-upload outage should not gate the build. Runs tokenless, matching the previous uploader. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
PavelPashov
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Upload to Codecov" step manually fetched Codecov's PGP key from keybase.io with a bare curl, then verified and ran the standalone uploader. keybase.io is a deprecated/unreliable key source; when it serves non-key content the gpg import returns non-zero and the whole step exits 2, reddening otherwise-green builds.
The root cause is now confirmed upstream: codecov-action v7.0.0 notes that the
codecovsecuritykeybase account was deleted (migration issues) and replaced withcodecovsecops. The inlined step verified against the now-deleted account, so it could never succeed.Swap the manual block for codecov/codecov-action@v7, which handles key verification and retries internally against the current account. fail_ci_if_error: false preserves the prior best-effort intent — a coverage-upload outage should not gate the build. Runs tokenless, matching the previous uploader.
Description
Checklist
npm testpass with this change (including linting)?Note
Low Risk
CI-only change to coverage upload; no application or security logic affected.
Overview
Replaces the manual Codecov upload in the composite
run-testsaction (curl from keybase.io, GPG verify, standalonecodecovbinary) withcodecov/codecov-action@v7, which uses current upstream key handling after the oldcodecovsecurityKeybase account was removed.Sets
fail_ci_if_error: falseso coverage upload failures still do not fail CI, matching prior best-effort behavior. Upload remains tokenless like before.Reviewed by Cursor Bugbot for commit 5671095. Bugbot is set up for automated code reviews on this repo. Configure here.