Repository navigation
fix: prevent reconnect loop with legacy quit - #3462
Merged
Merged
Conversation
Contributor
Author
|
review please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
legacy.quit()handling.Closes #2273
Note
Low Risk
Narrow legacy-mode lifecycle fix with a targeted regression test; no auth or data-path changes.
Overview
Fixes legacy-mode
quitso it no longer behaves like a normal Redis command from the auto-generated command map, which could leave the connection in a bad state and trigger unwanted reconnect attempts.RedisLegacyClientnow exposes an explicitquitthat forwards to#client.quit(), with the same optional callback /error-event behavior as other legacy APIs. A regression test asserts that afterlegacy.quit, the underlying client is closed (isOpenis false) and noreconnectingevents fire.Reviewed by Cursor Bugbot for commit 5829c9d. Bugbot is set up for automated code reviews on this repo. Configure here.