Repository navigation
fix(client): preserve empty XPENDING consumer filters - #3494
Merged
nkaradzhov merged 1 commit intoOct 8, 2026
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
xPendingRange(..., { consumer: '' })drops the consumer filter because the parser tests truthiness. Check againstundefinedto preserve an empty name, consistent with an empty Buffer, and clarify the option's JSDoc. Omitted and undefined consumers remain omitted.Add ten argument regressions covering strings, Buffers, zero IDLE, and omitted/undefined consumers. The two empty-string cases fail before the fix; all ten pass afterward.
Validation:
5033f59.This is a source-discovered, isolated bug fix; no existing issue is being claimed. OpenAI Codex assisted with investigation, code, tests, and this description.
Checklist
npm testpass with this change (including linting)? The full workspace suite and changed-file lint pass in all ten cloud jobs, using the same cleanup/workspace commands as rootnpm testwith upstream Redis flags.Note
Low Risk
Isolated XPENDING RANGE argument serialization fix with new regression tests; no auth, data, or broader API changes.
Overview
Fixes
xPendingRangeso an explicitconsumer: ''(or emptyBuffer) is still sent to Redis instead of being dropped by a truthy check.The parser now appends the consumer only when
options.consumer !== undefined, matching behavior for omitted/undefinedconsumers and aligning withIDLE: 0handling. JSDoc notes that empty consumer names are valid.Adds argument-parsing regressions for empty/nonempty strings and buffers, with and without
IDLE: 0, plus cases where the consumer is omitted orundefined.Reviewed by Cursor Bugbot for commit 85f255a. Bugbot is set up for automated code reviews on this repo. Configure here.