← 输入框|github.com|刷新
Skip to content

Exclude generated release output from VCS build metadata - #26

Merged
satococoa merged 1 commit into
mainfrom
codex/ignore-release-output-20261103
Nov 3, 2026
Merged

satococoa merged 1 commit into
mainfrom
codex/ignore-release-output-20261103

Conversation

@satococoa

Copy link
Copy Markdown
Owner

GoReleaser creates dist/metadata.json before building. Because /dist/ was not ignored, otherwise clean release binaries embedded vcs.modified=true and a +dirty module version. Ignore only the root release-output directory so generated artifacts do not mark the source checkout as modified.

Validated the cause with three builds: clean checkout → clean; generated dist file → dirty; ignored dist → clean. Real tracked-source modifications still report dirty. A full GoReleaser v2.19.0 snapshot produced all four configured binaries with vcs.modified=false.

make ci passed (format, vet, lint, tests and race). The snapshot Linux binary passed ignored/tracked protection, conflict, unchanged dry-run, JSON and exit-code smoke checks. No application behavior or source-install version-output change.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@satococoa
satococoa marked this pull request as ready for review November 3, 2026 13:50
@satococoa
satococoa merged commit 892058a into main Nov 3, 2026
5 checks passed
@satococoa
satococoa deleted the codex/ignore-release-output-20261103 branch November 3, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant