Repository navigation
Exclude generated release output from VCS build metadata - #26
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Tip 🎯 Customize your risk assessments
✅ Automatic approvals, with your rules
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoReleaser creates
dist/metadata.jsonbefore building. Because/dist/was not ignored, otherwise clean release binaries embeddedvcs.modified=trueand a+dirtymodule version. Ignore only the root release-output directory so generated artifacts do not mark the source checkout as modified.Validated the cause with three builds: clean checkout → clean; generated dist file → dirty; ignored dist → clean. Real tracked-source modifications still report dirty. A full GoReleaser v2.19.0 snapshot produced all four configured binaries with
vcs.modified=false.make cipassed (format, vet, lint, tests and race). The snapshot Linux binary passed ignored/tracked protection, conflict, unchanged dry-run, JSON and exit-code smoke checks. No application behavior or source-install version-output change.