Repository navigation
Fix tag element regex #170
Description
The tagElementSeparator pattern currently splits unpaired single quotes ('). As single quotes are often used as apostrophes, this results in a sentence like "The FunctionalInterface's method" being split to two elements, which then causes the op parser to barf because it thinks it has extra param annotations, or is missing its return annotation, etc...
Activity
ctrueden commentedon Dec 14, 2023
If only there were some kind of proper parser instead of relying on a fragile regex here...? 🤡
hinerm commentedon Dec 18, 2023
I tried looking at this and my first thought was the trailing
[^']*should just be.*so that the pattern doesn't stop at singleton'. But then it starts failing on any multi-line@param.i.e.
This op no longer compiles with this patch:
I find this concerning and am skeptical we are parsing what we think we are, particularly for any multi-line javadoc. But it works right now so I also don't know that fiddling with this regex is useful right now.