← 输入框|github.com|刷新
Skip to content

Modularize SciJava Ops FLIM #207

Open

Description

@gselzer

When I wrote scijava/incubator#125, I attempted to create a JPMS module scijava-ops-flim, however I ran into issues with native code access. As a part of that PR, I wrote a commit that deleted my partial module-info.java, however it would be ideal if we can figure out how to modularize it.

Activity

  1. added this to the unscheduled milestone on Apr 2, 2024
  2. ctrueden commented on May 22, 2024

    @ctrueden
    Member

    Unfortunately, scijava-ops-flim not being modularized results in javadoc build errors:

    [ERROR] javadoc: error - The code being documented uses packages in the unnamed module, but the packages defined in https://github.com/scijava/scijava-concurrent/apidocs/ are in named modules.
    [ERROR] javadoc: error - The code being documented uses packages in the unnamed module, but the packages defined in https://github.com/scijava/scijava-ops-spi/apidocs/ are in named modules.
    [ERROR] javadoc: error - The code being documented uses packages in the unnamed module, but the packages defined in https://github.com/scijava/scijava/apidocs/ are in named modules.
    [ERROR] javadoc: error - The code being documented uses packages in the unnamed module, but the packages defined in https://github.com/scijava/scijava-types/apidocs/ are in named modules.
    

    This suggests to me that anyone attempting to link to javadoc of SciJava Ops components, without using JPMS themselves, will run into this problem as well. I am looking into what can be done to mitigate it.

    Edit: setting <doclint>none</doclint> in the scijava-ops-flim POM does not squelch the errors.

    Edit: it is a bug in javadoc which is marked fixed as of Java 18. The fix seems to have been backported, because when running mvn clean test javadoc:javadoc with Zulu OpenJDK 11.0.23+9, it works, whereas I received the above errors when using AdoptOpenJDK 11.0.8+10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions