Repository navigation
Clean up installation into scijava.app.directory #221
Description
Currently, when running mvn install -Dscijava.app.directory="/path/to/Fiji.app" the following superfluous jars are installed:
scijava-ops-ext-parserscijava-ops-indexerscijava-ops-tutorialscijava-testutilscijava-discovery-test
We don't want any of these.
Other fixes:
- platform-specific native jars go into the
/jarsdirectory instead of/jars/[platform] apiguardianjar is included but I think we don't want it?
Reacted by Gabriel Selzer
Activity
gselzer commentedon May 20, 2024
@hinerm @ctrueden does the maven-scijava-plugin provide a mechanism for skipping the scijava:populate-app goal? I don't really understand how you'd prevent installation...
hinerm commentedon May 20, 2024
@gselzer I think we'd have to isolate the unwanted dependencies and modules.. e.g. with different dependency scopes or Maven profiles. I am doubtful that it is something that can/should be handled at the maven-scijava-plugin level.
ctrueden commentedon May 20, 2024
This suggests to me that perhaps those specific modules should be put behind profile(s), so that their inclusion in the build is opt-in (and therefore their installation via populate-app is opt-in).
@hinerm Is scijava-maven-plugin >=2.0.0 being used? I thought I fixed this issue years ago as described here?
This dependency comes in because scijava-testutil depends on junit-jupiter-api at compile scope, so the apiguardian dependency comes in transitively also at compile scope. If we hide scijava-testutil behind a profile, this artifact will not be included in app installation.
ctrueden commentedon May 30, 2024
Upon reflection, I think instead we should add some kind of skip property to the scijava-maven-plugin's install-artifact goal. That way, we can still have the whole suite build and run tests and even be
mvn installed, but not copy them into aFiji.app.