Repository navigation
Conversation
Reduced and converted op wrappers derive a class name from the parameter types, replacing "[]" with "_Arr". This was done only one level deep, so a parameter such as double[][] produced an invalid class name and the op could not be called with its optional parameters omitted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fix for generated class names of nested array types (a14c733e9) was only exercised indirectly by color.deconvolveStains in scijava-ops-image. NestedArrayParameterTest calls ops with double[][] and double[][][] parameters with a @nullable parameter omitted (reduced wrapper), and with a converted argument and output; without the fix, the reduced calls fail. The converted wrapper name is not compiled into a class on that path, so ConversionTest checks Conversions.getClassName directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gselzer
requested changes
Oct 27, 2026
Comment on lines
+1
to
+7
| # Changelog | ||
|
|
||
| All notable changes to SciJava Ops Engine. | ||
|
|
||
| ## [Unreleased] | ||
|
|
||
| ### Fixed |
Member
There was a problem hiding this comment.
Are we going to start keeping changelogs?
Comment on lines
+119
to
+128
| /** An Integer scale goes through a converted wrapper. */ | ||
| @Test | ||
| public void testConverted() { | ||
| final Double sum = ops.op("test.nestedArraySum").input(VALUES, 3) | ||
| .outType(Double.class).apply(); | ||
| assertEquals(30, sum, 0); | ||
| final Integer rounded = ops.op("test.nestedArraySum").input(VALUES) | ||
| .outType(Integer.class).apply(); | ||
| assertEquals(10, rounded); | ||
| } |
Member
There was a problem hiding this comment.
This should probably go somewhere in the org.scijava.ops.engine.matcher.convert package?
Member
There was a problem hiding this comment.
Mostly suggesting this because we are adding a bunch of Ops to the test environment above, most of which aren't needed to test the reduction fix.
| @@ -174,9 +174,10 @@ private static String memberNames(ReducedOpInfo reducedInfo) { | |||
| */ | |||
| private static String getClassName(Class<?> clazz) { | |||
Member
There was a problem hiding this comment.
It is obnoxious that we have two identical functions that we have to fix, but probably not worth unifying them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class names generated for reduced and converted op wrappers only handled one level of array nesting, so an op with a
double[][]parameter failed with "…double[]_Arr is not a valid class name!" when called with its optional parameters omitted, or with converted arguments.This is a one-line fix in each of
ReductionUtilsandConversions, plus engine tests coveringdouble[][]anddouble[][][]parameters.